forked from AntelopeIO/leap
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slim account #1
Closed
Closed
Slim account #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you need to make changes here:
leap/libraries/chain/eosio_contract.cpp
Lines 345 to 350 in b691432
if( update.permission == config::active_name ) | |
EOS_ASSERT(update.parent == config::owner_name, action_validate_exception, "Cannot change active authority's parent from owner", ("update.parent", update.parent) ); | |
if (update.permission == config::owner_name) | |
EOS_ASSERT(update.parent.empty(), action_validate_exception, "Cannot change owner authority's parent"); | |
else | |
EOS_ASSERT(!update.parent.empty(), action_validate_exception, "Only owner permission can have empty parent" ); |
otherwise you will be unable to change a slim accounts active key after account creation.
replaced by #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This MR introduces a significant optimization in RAM usage by implementing a new account structure. The changes are designed to enhance efficiency and reduce the memory. The key modifications include:
account_object
is now universal for all account types, while theaccount_metadata_object
is specifically applied for smart contract accountsaccount_object
,resource_object
, and one ACTIVE permission. Unlike regular accounts, Slim accounts don't have the OWNER permission by default. A Slim account uses up to 54% less RAM than a regular account.API Changes
New actions: eosio:: newslimacc
Documentation Additions
Documentation can be found here
Note
There are a couple of unresolved issues: